Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AgendaList): Allow user to control delay in scrollToSection #2503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bravesoul349
Copy link
Contributor

Solves #2194

@bravesoul349
Copy link
Contributor Author

bravesoul349 commented Aug 4, 2024

I have set the default value to 0 because this is the expected default behaviour by most of the users to have no delay.

@bravesoul349 bravesoul349 changed the title [AgendaList] Allow user to control delay in scrollToSection fix(AgendaList): Allow user to control delay in scrollToSection Aug 4, 2024
@Inbal-Tish
Copy link
Collaborator

I have set the default value to 0 because this is the expected default behaviour by most of the users to have no delay.

The delay is intentional, without which the debounce is meaningless... I understand the need to control this delay but the default should be kept to the current behavior otherwise this might cause issues to current implementations that relay on this delay.

@bravesoul349
Copy link
Contributor Author

I have set the default value to 0 because this is the expected default behaviour by most of the users to have no delay.

The delay is intentional, without which the debounce is meaningless... I understand the need to control this delay but the default should be kept to the current behavior otherwise this might cause issues to current implementations that relay on this delay.

I have updated the code as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants